Do follow-up requests on incomplete type responses #1666
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Cyclone issues a type lookup request for a type T and all its dependencies, it necessarily includes only those dependencies that is aware of. The types learnt from the response may themselves introduce unknown dependencies.
That means that wait_for_type_resolved_impl_locked may have to issue follow-up requests.
@dpotman Perhaps you can have a look? I'm not sure this is the best way to do it. It does the trick for
dynsub
ondyntype
but that doesn't mean it is good. I'm particularly worried that it could possibly result in a request storm, and that would be quite bad.